Re: [Xen-devel] [PATCH 1/4] tools: install under /usr/local by default.

[Matt Wilson <msw@xxxxxxxxxx>]

On Fri, Jan 18, 2013 at 02:25:37PM +0000, Ian Campbell wrote:
> This is the defacto (or FHS mandated?) standard location for software
> built from source, in order to avoid clashing with packaged software
> which is installed under /usr/bin etc.
> 
> I think there is benefit in having Xen's install behave more like the
> majority of other OSS software out there.
> 
> The major downside here is in the transition from 4.2 to 4.3 where
> people who have built from source will innevitably discover breakage
> because 4.3 no longer overwrites stuff in /usr like it used to so they
> pickup old stale bits from /usr instead of new stuff from /usr/local.
> 
> Packages will use ./configure --prefix=/usr or whatever helper macro
> their package manager gives them. I have confirmed that doing this
> results in the same list of installed files as before this patch was
> applied.
> 
> Note that this does not currently affect docs or stubdoms at the
> moment, so they still end up under /usr. There are proposals to use
> configure here too at which point I would propose a similar patch and
> these would also move as expected (depending on the sequencing I may
> end folding that into this patch)
> 
> The hypervisor remains in /boot/ and there is no intention to move it.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Acked-by: Matt Wilson <msw@xxxxxxxxxx>

> ---
>  configure            |    2 --
>  configure.ac         |    1 -
>  stubdom/configure    |    2 --
>  stubdom/configure.ac |    1 -
>  tools/configure      |    2 --
>  tools/configure.ac   |    1 -
>  6 files changed, 0 insertions(+), 9 deletions(-)
> 
> diff --git a/configure b/configure
> index 2c1f5bc..cbc38ba 100755
> --- a/configure
> +++ b/configure
> @@ -557,7 +557,6 @@ PACKAGE_BUGREPORT='xen-devel@xxxxxxxxxxxxx'
>  PACKAGE_URL='http://www.xen.org/'
>  
>  ac_unique_file="./xen/common/kernel.c"
> -ac_default_prefix=/usr
>  enable_option_checking=no
>  ac_subst_vars='LTLIBOBJS
>  LIBOBJS
> @@ -1669,7 +1668,6 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu
>  
>  
>  
> -
>  ac_config_files="$ac_config_files ./config/Toplevel.mk"
>  
>  
> diff --git a/configure.ac b/configure.ac
> index fcbc4ae..b17e671 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -5,7 +5,6 @@ AC_PREREQ([2.67])
>  AC_INIT([Xen Hypervisor], m4_esyscmd([./version.sh ./xen/Makefile]),
>      [xen-devel@xxxxxxxxxxxxx], [xen], [http://www.xen.org/])
>  AC_CONFIG_SRCDIR([./xen/common/kernel.c])
> -AC_PREFIX_DEFAULT([/usr])
>  AC_CONFIG_FILES([./config/Toplevel.mk])
>  
>  m4_include([m4/features.m4])
> diff --git a/stubdom/configure b/stubdom/configure
> index ab9219a..51ca676 100755
> --- a/stubdom/configure
> +++ b/stubdom/configure
> @@ -557,7 +557,6 @@ PACKAGE_BUGREPORT='xen-devel@xxxxxxxxxxxxx'
>  PACKAGE_URL='http://www.xen.org/'
>  
>  ac_unique_file="../extras/mini-os/kernel.c"
> -ac_default_prefix=/usr
>  ac_subst_vars='LTLIBOBJS
>  LIBOBJS
>  STUBDOM_INSTALL
> @@ -1792,7 +1791,6 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu
>  
>  ac_config_files="$ac_config_files ../config/Stubdom.mk"
>  
> -
>  ac_aux_dir=
>  for ac_dir in ../ "$srcdir"/../; do
>    if test -f "$ac_dir/install-sh"; then
> diff --git a/stubdom/configure.ac b/stubdom/configure.ac
> index 2b7b275..de29fb5 100644
> --- a/stubdom/configure.ac
> +++ b/stubdom/configure.ac
> @@ -6,7 +6,6 @@ AC_INIT([Xen Hypervisor Stub Domains], 
> m4_esyscmd([../version.sh ../xen/Makefile
>      [xen-devel@xxxxxxxxxxxxx], [xen], [http://www.xen.org/])
>  AC_CONFIG_SRCDIR([../extras/mini-os/kernel.c])
>  AC_CONFIG_FILES([../config/Stubdom.mk])
> -AC_PREFIX_DEFAULT([/usr])
>  AC_CONFIG_AUX_DIR([../])
>  
>  # M4 Macro includes
> diff --git a/tools/configure b/tools/configure
> index 898dd17..1f33858 100755
> --- a/tools/configure
> +++ b/tools/configure
> @@ -558,7 +558,6 @@ PACKAGE_BUGREPORT='xen-devel@xxxxxxxxxxxxx'
>  PACKAGE_URL='http://www.xen.org/'
>  
>  ac_unique_file="libxl/libxl.c"
> -ac_default_prefix=/usr
>  # Factoring default headers for most tests.
>  ac_includes_default="\
>  #include <stdio.h>
> @@ -2145,7 +2144,6 @@ ac_config_files="$ac_config_files ../config/Tools.mk"
>  
>  ac_config_headers="$ac_config_headers config.h"
>  
> -
>  ac_aux_dir=
>  for ac_dir in ../ "$srcdir"/../; do
>    if test -f "$ac_dir/install-sh"; then
> diff --git a/tools/configure.ac b/tools/configure.ac
> index 2bd71b6..4411f63 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -7,7 +7,6 @@ AC_INIT([Xen Hypervisor Tools], m4_esyscmd([../version.sh 
> ../xen/Makefile]),
>  AC_CONFIG_SRCDIR([libxl/libxl.c])
>  AC_CONFIG_FILES([../config/Tools.mk])
>  AC_CONFIG_HEADERS([config.h])
> -AC_PREFIX_DEFAULT([/usr])
>  AC_CONFIG_AUX_DIR([../])
>  
>  # Check if CFLAGS, LDFLAGS, LIBS, CPPFLAGS or CPP is set and print a warning
> -- 
> 1.7.2.5
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel