Re: [Xen-devel] [PATCH 9 of 9 RFC v2] blktap3/libblktapctl: Introduce makefile that builds tapback-required libblktapctl functionality

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-12-04 at 18:19 +0000, Thanos Makatos wrote:
> diff --git a/config/StdGNU.mk b/config/StdGNU.mk
> --- a/config/StdGNU.mk
> +++ b/config/StdGNU.mk
> @@ -77,3 +77,6 @@ ifeq ($(lto),y)
>  CFLAGS += -flto
>  LDFLAGS-$(clang) += -plugin LLVMgold.so
>  endif
> +
> +TAPDISK_EXEC = "tapdisk"
> +TAPDISK_EXECDIR = $(LIBEXEC) 

Do these need to be configurable?

I'd be tempted to suggest that you just do 
        #define TAPDISK_EXEC "tapdisk"
        #define TAPDISK_EXECDIR LIBEXEC
in one of you headers.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel