Re: [Xen-devel] [PATCH v2 3/4] nested vmx: optimize for bulk access of virtual VMCS

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.01.13 at 07:07, Dongxiao Xu <dongxiao.xu@xxxxxxxxx> wrote:
> +static void vvmcs_to_shadow_bulk(void *vvmcs, unsigned int n, const u16 
> *field)
> +{
> +    u64 *value;
> +    unsigned int i = 0;

The pointless initializer is still there (also again further down).

> @@ -863,13 +919,18 @@ static void load_shadow_guest_state(struct vcpu *v)
>  {
>      struct nestedvcpu *nvcpu = &vcpu_nestedhvm(v);
>      void *vvmcs = nvcpu->nv_vvmcx;
> -    int i;
>      u32 control;
>      u64 cr_gh_mask, cr_read_shadow;
>  
> +    const u16 vmentry_fields[] = {

static (also elsewhere)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel