Re: [Xen-devel] [PATCH VTPM v8 0/8] Vtpm patch set

["Fioravante, Matthew E." <Matthew.Fioravante@xxxxxxxxxx>]

> -----Original Message-----
> From: Ian Campbell [mailto:Ian.Campbell@xxxxxxxxxx]
> Sent: Friday, January 11, 2013 11:33 AM
> To: Fioravante, Matthew E.
> Cc: xen-devel
> Subject: Re: [PATCH VTPM v8 0/8] Vtpm patch set
> 
> Putting list back again.
> 
> On Fri, 2013-01-11 at 16:25 +0000, Fioravante, Matthew E. wrote:
> > > CMAKE_BUILD_TYPE is blank for me.
> >
> > Ok I think thatâs the bug. It looks like the default value of
> > BUILD_TYPE is dependent on the compiler.
> >
> > Can you try changing the line in stubdom/Makefile to do
> > -DCMAKE_C_FLAGS_RELEASE=<stuff> and and add
> > -DCMAKE_BUILD_TYPE=Release. Then do a make cross-tpmemu and see if
> > TPM_NO_EXTERN was set in the build.
> 
> I applied:
> diff --git a/stubdom/Makefile b/stubdom/Makefile index 3006ad6..a74480e
> 100644
> --- a/stubdom/Makefile
> +++ b/stubdom/Makefile
> @@ -208,7 +208,7 @@ tpm_emulator-$(XEN_TARGET_ARCH): tpm_emulator-
> $(TPMEMU_VERSION).tar.gz
>       mv tpm_emulator-$(TPMEMU_VERSION) $@
>       patch -d $@ -p1 < tpmemu-$(TPMEMU_VERSION).patch;
>       mkdir $@/build
> -     cd $@/build; $(CMAKE) .. -DCMAKE_C_COMPILER=${CC} -
> DCMAKE_C_FLAGS="-std=c99 -DTPM_NO_EXTERN $(TARGET_CPPFLAGS)
> $(TARGET_CFLAGS) -Wno-declaration-after-statement"
> +     cd $@/build; $(CMAKE) .. -DCMAKE_C_COMPILER=${CC}
> +-DCMAKE_C_FLAGS_RELEASE="-std=c99 -DTPM_NO_EXTERN
> $(TARGET_CPPFLAGS)
> +$(TARGET_CFLAGS) -Wno-declaration-after-statement"
> +-DCMAKE_BUILD_TYPE=Release
>       touch $@
> 
>  TPMEMU_STAMPFILE=$(CROSS_ROOT)/$(GNU_TARGET_ARCH)-xen-
> elf/lib/libtpm.a
> 
> Is this what you meant?
> 
> $ rm ./cross-root-x86_64/x86_64-xen-elf/lib/libtpm.a
> $ rm -rf tpm_emulator-x86_64/
> $ make cross-tpmemu
> 
> I don't see NO_EXTERN anywhere apart from the initial invocation of CMAKE
> and I still see the undesired symbols in tpm_emulator-
> x86_64/build/tpm/CMakeFiles/tpm.dir/tpm_emulator_extern.o
> 
> ccmake does say release now though.
Yes thatâs what I meant. One more thing to try. Keep the BUILD_TYPE but set 
CMAKE_C_FLAGS_RELEASE back to CMAKE_C_FLAGS. If that doesn't work I'll have to 
do some more digging myself.
> 
> Ian.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel