[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH VTPM v8 6/8] stubdom: Add autoconf

On 01/10/2013 11:28 AM, Ian Campbell wrote:
On Thu, 2013-01-10 at 15:38 +0000, Matthew Fioravante wrote:
On 01/10/2013 10:35 AM, Ian Campbell wrote:
On Thu, 2013-01-03 at 15:37 +0000, Matthew Fioravante wrote:
+AX_STUBDOM_CONDITIONAL([vtpm-stubdom], [vtpm])
+AX_STUBDOM_CONDITIONAL([vtpmmgrdom], [vtpmmgr])
Any reason for vtpmmgrdom rather than vtpmmgr-stubdom like (most of) the
others? (the exception being pv-grub)
No reason at all, thats just what I named it. Would you prefer
vtpmmgr-stubdom instead?
Yes, although I realize that might be a bit OCD of me.
Not a major change, can do.
Also vtpmmgr isn't actually conditional, was it supposed to be?
It doesn't need to be, I can make it default enabled. Thats pretty much
what the configure script does already.
Would it make sense to conditionally only build vtpmmgr if we have built
the vtpm stub dom too? If so lets do that, if not then lets switch to
the default enabled thing.
I kind of had this thought as well. Although someone might want to build only vtpmmgr if they are implementing their own vtpm. Still in that case they could explicitly do --disable-vtpm-stubdom --enable-vtpmmgrdom



Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.