Re: [Xen-devel] Failure to Parse and Load C-States

[Tom Goetz <thomas.goetz@xxxxxxxxxx>]

On Jan 4, 2013, at 4:16 PM, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 
wrote:

> On Thu, Jan 03, 2013 at 01:53:04PM -0500, Tom Goetz wrote:
>> Konrad,
>> 
>> We're seeing a failure where c-states are not parsed and loaded to the 
>> hypervisor.
>> 
>> What is happening is when the following calls happen, there are no c-states 
>> in the per CPU data.
>> 
>> [    1.954368]  [<ffffffff8157840e>] push_cxx_to_hypervisor+0x1a5/0x2d5
>> [    1.954374]  [<ffffffff815785ab>] upload_pm_data+0x6d/0xa2
>> [    1.954380]  [<ffffffff81afe101>] xen_acpi_processor_init+0x3c3/0x488
>> 
>> It looks like the c-state parsing should have happened in 
>> acpi_processor_power_init but didn't because of the following check at the 
>> top:
>> 
>>        if (disabled_by_idle_boot_param())
>>                return 0;
>> 
>> The preceding is true because boot_option_idle_override is set to IDLE_HALT 
>> by arch/x86/xen/setup.c xen_arch_setup.
>> 
>> Is the Xen version of acpi_processor supposed to do it's own c-state parsing 
>> or rely on the base acpi_processor c-state parsing? I'm assuming Xen sets 
>> IDLE_HALT to stop runtime usage of Linux c-state management, but it also 
>> stops parsing c-states.
>> 
>> Linux: 3.2.23
> 
> I believe you are missing some patches to cpufreq.c and setup.c, which are:
> 

...

> 
> 
> commit cc7335b2f6acc0f24c7fac80ce536301f7d52214
> Author: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Date:   Mon Jan 23 10:53:57 2012 -0500
> 
>    xen/setup/pm/acpi: Remove the call to boot_option_idle_override.

Missing this one.

As Ben mentioned in his email, we were missing one of the patches you pointed 
us to. Thanks for all of the help. I'll buy you a beer too!

-Tom


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel