Re: [Xen-devel] [PATCH V3] Switch from select() to poll() in xenconsoled's IO loop.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> > >                         handle_xs();
> > > 
> > >                 for (d = dom_head; d; d = n) {
> > >                         n = d->next;
> > >                         if (d->event_count < RATE_LIMIT_ALLOWANCE) {
> > >                                 if (d->xce_handle != NULL &&
> > > -                                   FD_ISSET(xc_evtchn_fd(d->xce_handle),
> > > -                                            &readfds))
> > > +                                   
> > > fd_revents(xc_evtchn_fd(d->xce_handle)) &
> > 
> > ... adding some struct pollfd pointers to struct domain (for this and
> > master_fd) would remove the need for the fd_to_pollfd lookup array
> > altogether.
> > 
> 
> Yes, this is possible. But my original thought was to make as little
> impact to original code as possible, so I didn't touch struct domain and
> choose to add extra tracking facilities to make it just work.

I think adding a few pointers to struct domain would be less code
changed over all since you wouldn't need to create/manage one of the
arrays at all.

> If we hit poll() bottleneck we can move to libevent or libev, which
> requires big surgery on existing code.
> 
> Of course I can do that as well if that suits you.
> 
> 
> Wei.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel