[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0/8] IOMMU: add phantom function support



Looks fine to me. Thanks, Jan!   
Acked for this series of the patch.  
Xiantao

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Thursday, December 06, 2012 10:05 PM
> To: xen-devel
> Cc: Wei Huang; Wei Wang; Zhang, Xiantao
> Subject: [PATCH 0/8] IOMMU: add phantom function support
> 
> While I'm unaware of devices making use of this functionality in
> proper ways, the goal of this patch set is to leverage the enabling
> of the specified behavior as a workaround for devices that behave
> as if they made use of this functionality _without_ advertising so
> in the PCIe capability structure.
> 
> While it would have been possible to leave the generic IOMMU
> code untouched, and deal with the creation of the necessary
> device context entries in the individual IOMMUs' implementations,
> I felt that it was cleaner to have as much of the necessary
> abstraction in the generic layer.
> 
> The adjustments in particular imply that for the relevant
> operations, (PCI-dev, devfn) tuples get passed, with the PCI
> device referring to the real device and devfn representing
> either the real device or the phantom function. Consequently,
> for any operation intended to deal with the real device, the
> devfn of the device itself must be used, whereas for anything
> targeting the phantom function the passed in value is the
> correct one to pass on.
> 
> 1: IOMMU: adjust (re)assign operation parameters
> 2: IOMMU: adjust add/remove operation parameters
> 3: VT-d: adjust context map/unmap parameters
> 4: AMD IOMMU: adjust flush function parameters
> 5: IOMMU: consolidate pdev_type() and cache its result for a given device
> 6: IOMMU: add phantom function support
> 7: VT-d: relax source qualifier for MSI of phantom functions
> 8: IOMMU: add option to specify devices behaving like ones using phantom
> functions
> 
> The patch set meanwhile got tested on the affected systems.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.