Re: [Xen-devel] [PATCH 3/5] xen: arm: head.S PT_DEV is unused, drop and rename PT_DEV_L3

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-12-20 at 11:24 +0000, Ian Campbell wrote:
> On Thu, 2012-12-20 at 11:21 +0000, Tim Deegan wrote:
> > At 14:54 +0000 on 19 Dec (1355928840), Ian Campbell wrote:
> > > On Wed, 2012-12-19 at 11:22 +0000, Ian Campbell wrote:
> > > > On Wed, 2012-12-19 at 10:49 +0000, Tim Deegan wrote:
> > > > > At 10:20 +0000 on 19 Dec (1355912423), Ian Campbell wrote:
> > > > > > On Tue, 2012-12-18 at 18:33 +0000, Stefano Stabellini wrote:
> > > > > > > On Tue, 18 Dec 2012, Ian Campbell wrote:
> > > > > > > > This shortens an overly long line.
> > > > > > > > 
> > > > > > > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > > > > > 
> > > > > > > honestly I would rather keep it because it has been quite useful 
> > > > > > > for
> > > > > > > debugging in the past once all the bugs have been fixed (TM) then 
> > > > > > > we can
> > > > > > > remove it ;-)
> > > > > > 
> > > > > > Can you not just re-add it for debug?
> > > > > > 
> > > > > > I mostly just want to get rid of the overlong line, I could nuke the
> > > > > > spaces from the comment (in all of them, not just this one) instead?
> > > > > 
> > > > > Could you just remove the 'lev3: ' from the comment, pulling it in to
> > > > > exactly 80 chars?  Your' added 'second level' and 'third level' make 
> > > > > it
> > > > > redundant, and I'd rather not lose the spaces in the comments.
> > > > 
> > > > I think that makes it exactly 80 characters, which is probably ok.
> > > 
> > > It ends up as below, exactly 80 characters long. I think it's probably
> > > not worth it.
> > 
> > OK, how's this?
> > 
> > arm: trim pagetable flag definitions to fit in 80 characters
> > 
> > Signed-off-by: Tim Deegan <tim@xxxxxxx>
> 
> Lateral thought ;-)
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I applied this last year and forgot to push. Now done.

Ian


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel