Re: [Xen-devel] [PATCH 05 of 10 v2] libxc: allow for explicitly specifying node-affinity

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Fri, 2012-12-21 at 15:19 +0000, George Dunlap wrote: 
> On 19/12/12 19:07, Dario Faggioli wrote:
> > By providing the proper get/set interface and wiring them
> > to the new domctl-s from the previous commit.
> >
> > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > Acked-by: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
> 
> I haven't done a detailed review, but everything looks OK:
> 
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> 
Ok. Also, let me use this e-mail to thank you properly for the thorough,
useful and especially quick review! All you said was really useful, I'll
do my best do address the points you raised in a proper and equally
quick manner.

See you in 2013 (I'm going on vacation today) with v3!  :-D

Thanks again and Regards,
Dario

> >
> > diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
> > --- a/tools/libxc/xc_domain.c
> > +++ b/tools/libxc/xc_domain.c
> > @@ -110,6 +110,83 @@ int xc_domain_shutdown(xc_interface *xch
> >   }
> >   
> >   
> > +int xc_domain_node_setaffinity(xc_interface *xch,
> > +                               uint32_t domid,
> > +                               xc_nodemap_t nodemap)
> > +{
> > +    DECLARE_DOMCTL;
> > +    DECLARE_HYPERCALL_BUFFER(uint8_t, local);
> > +    int ret = -1;
> > +    int nodesize;
> > +
> > +    nodesize = xc_get_nodemap_size(xch);
> > +    if (!nodesize)
> > +    {
> > +        PERROR("Could not get number of nodes");
> > +        goto out;
> > +    }
> > +
> > +    local = xc_hypercall_buffer_alloc(xch, local, nodesize);
> > +    if ( local == NULL )
> > +    {
> > +        PERROR("Could not allocate memory for setnodeaffinity domctl 
> > hypercall");
> > +        goto out;
> > +    }
> > +
> > +    domctl.cmd = XEN_DOMCTL_setnodeaffinity;
> > +    domctl.domain = (domid_t)domid;
> > +
> > +    memcpy(local, nodemap, nodesize);
> > +    set_xen_guest_handle(domctl.u.nodeaffinity.nodemap.bitmap, local);
> > +    domctl.u.nodeaffinity.nodemap.nr_elems = nodesize * 8;
> > +
> > +    ret = do_domctl(xch, &domctl);
> > +
> > +    xc_hypercall_buffer_free(xch, local);
> > +
> > + out:
> > +    return ret;
> > +}
> > +
> > +int xc_domain_node_getaffinity(xc_interface *xch,
> > +                               uint32_t domid,
> > +                               xc_nodemap_t nodemap)
> > +{
> > +    DECLARE_DOMCTL;
> > +    DECLARE_HYPERCALL_BUFFER(uint8_t, local);
> > +    int ret = -1;
> > +    int nodesize;
> > +
> > +    nodesize = xc_get_nodemap_size(xch);
> > +    if (!nodesize)
> > +    {
> > +        PERROR("Could not get number of nodes");
> > +        goto out;
> > +    }
> > +
> > +    local = xc_hypercall_buffer_alloc(xch, local, nodesize);
> > +    if ( local == NULL )
> > +    {
> > +        PERROR("Could not allocate memory for getnodeaffinity domctl 
> > hypercall");
> > +        goto out;
> > +    }
> > +
> > +    domctl.cmd = XEN_DOMCTL_getnodeaffinity;
> > +    domctl.domain = (domid_t)domid;
> > +
> > +    set_xen_guest_handle(domctl.u.nodeaffinity.nodemap.bitmap, local);
> > +    domctl.u.nodeaffinity.nodemap.nr_elems = nodesize * 8;
> > +
> > +    ret = do_domctl(xch, &domctl);
> > +
> > +    memcpy(nodemap, local, nodesize);
> > +
> > +    xc_hypercall_buffer_free(xch, local);
> > +
> > + out:
> > +    return ret;
> > +}
> > +
> >   int xc_vcpu_setaffinity(xc_interface *xch,
> >                           uint32_t domid,
> >                           int vcpu,
> > diff --git a/tools/libxc/xenctrl.h b/tools/libxc/xenctrl.h
> > --- a/tools/libxc/xenctrl.h
> > +++ b/tools/libxc/xenctrl.h
> > @@ -521,6 +521,32 @@ int xc_watchdog(xc_interface *xch,
> >             uint32_t id,
> >             uint32_t timeout);
> >   
> > +/**
> > + * This function explicitly sets the host NUMA nodes the domain will
> > + * have affinity with.
> > + *
> > + * @parm xch a handle to an open hypervisor interface.
> > + * @parm domid the domain id one wants to set the affinity of.
> > + * @parm nodemap the map of the affine nodes.
> > + * @return 0 on success, -1 on failure.
> > + */
> > +int xc_domain_node_setaffinity(xc_interface *xch,
> > +                               uint32_t domind,
> > +                               xc_nodemap_t nodemap);
> > +
> > +/**
> > + * This function retrieves the host NUMA nodes the domain has
> > + * affinity with.
> > + *
> > + * @parm xch a handle to an open hypervisor interface.
> > + * @parm domid the domain id one wants to get the node affinity of.
> > + * @parm nodemap the map of the affine nodes.
> > + * @return 0 on success, -1 on failure.
> > + */
> > +int xc_domain_node_getaffinity(xc_interface *xch,
> > +                               uint32_t domind,
> > +                               xc_nodemap_t nodemap);
> > +
> >   int xc_vcpu_setaffinity(xc_interface *xch,
> >                           uint32_t domid,
> >                           int vcpu,
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel