[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 04 of 10 v2] xen: allow for explicitly specifying node-affinity
On Fri, 2012-12-21 at 15:17 +0000, George Dunlap wrote: > On 19/12/12 19:07, Dario Faggioli wrote: > > Make it possible to pass the node-affinity of a domain to the hypervisor > > from the upper layers, instead of always being computed automatically. > > > > Note that this also required generalizing the Flask hooks for setting > > and getting the affinity, so that they now deal with both vcpu and > > node affinity. > > > > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx> > > I can't comment on the XSM stuff > Right, it's the part I'm most week on too... Daniel had a go with this parch during v1's review, and he raised a couple of points that I think I addressed, let's see if he thinks there's anything else. > -- is any part of the "getvcpuaffinity" > stuff for XSM a public interface that needs to be backwards-compatible? > I.e., is s/vcpu//; OK from an interface point of view? > Mmm... Good point, I haven't thought about that. This was here in v1 and Daniel explicitly said he was fine with the renaming instead of adding a new hook, but mostly for the "semantic" point of view, not sure whether bkwrd compatibility is an issue... Daniel, what do you think? > WRT everything else: > Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx> > Ok. Thanks, Dario <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) Attachment:
signature.asc _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |