[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0/2] Add V4V to Xen (v8)



On 10/29/2012 02:37 AM, Jan Beulich wrote:
On 25.10.12 at 19:55, Jean Guyader <jean.guyader@xxxxxxxxxx> wrote:
v8 changes:
         - Move v4v private structures to v4v.c
         - fix padding
I still spotted at least one bogus padding field (in struct
v4v_ring_message_header, where no field is more than 4-byte
aligned afaict). Did you really carefully walk through all of them?

Hi Jan,
I am going to try and pilot this home, as I believe JeanG will not.

I just had a couple of questions about your comments that I hope you
could help me with.


Also, to validate the structures are really compatible between
native and compat mode guests, I'd strongly recommend adding
the leaf ones to xen/include/xlat.lst.

I'm sorry I don't understand.  What is xlat.lst ? And how does it help ?


Further I don't think you sync-ed up your patches with the
XEN_GUEST_HANDLE_PARAM() changes done for ARM, yet you
also didn't mention that the patch set is against other than the
tip of unstable.

Sorry, again I'm confused.  I thought all the Xen ARM changes went into
xen-unstable.
What other branches/trees do you think I need to post the v4v patch set against 
?



There appear to be plenty left (space between function name and
opening parenthesis, indentation inside switch statement, missing
parenthesization of macro expansion, missing newline between
declarations and statements are which I noticed without specifically
looking for them).


OK. This I can do.
dom

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.