Re: [Xen-devel] [PATCH v3 07/10] nEPT: Use minimal permission for nested p2m.

[Tim Deegan <tim@xxxxxxx>]

At 23:43 +0800 on 20 Dec (1356047028), Xiantao Zhang wrote:
> @@ -206,12 +205,14 @@ nestedhvm_hap_nested_page_fault(struct vcpu *v, paddr_t 
> *L2_gpa,
>      struct p2m_domain *p2m, *nested_p2m;
>      unsigned int page_order_21, page_order_10, page_order_20;
>      p2m_type_t p2mt_10;
> +    p2m_access_t p2ma_10 = p2m_access_rwx;
> +    uint8_t p2ma_21;
>  
>      p2m = p2m_get_hostp2m(d); /* L0 p2m */
>      nested_p2m = p2m_get_nestedp2m(v, nhvm_vcpu_p2m_base(v));
>  
>      /* walk the L1 P2M table */
> -    rv = nestedhap_walk_L1_p2m(v, *L2_gpa, &L1_gpa, &page_order_21,
> +    rv = nestedhap_walk_L1_p2m(v, *L2_gpa, &L1_gpa, &page_order_21, &p2ma_21,
>          access_r, access_w, access_x);

Once again, please either initialise p2ma_21 to rwx or have the SVM
version of this lookup set it to something sensible. 

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel