Re: [Xen-devel] [PATCH 3/5] xen: arm: head.S PT_DEV is unused, drop and rename PT_DEV_L3

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-12-19 at 11:22 +0000, Ian Campbell wrote:
> On Wed, 2012-12-19 at 10:49 +0000, Tim Deegan wrote:
> > At 10:20 +0000 on 19 Dec (1355912423), Ian Campbell wrote:
> > > On Tue, 2012-12-18 at 18:33 +0000, Stefano Stabellini wrote:
> > > > On Tue, 18 Dec 2012, Ian Campbell wrote:
> > > > > This shortens an overly long line.
> > > > > 
> > > > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > > 
> > > > honestly I would rather keep it because it has been quite useful for
> > > > debugging in the past once all the bugs have been fixed (TM) then we can
> > > > remove it ;-)
> > > 
> > > Can you not just re-add it for debug?
> > > 
> > > I mostly just want to get rid of the overlong line, I could nuke the
> > > spaces from the comment (in all of them, not just this one) instead?
> > 
> > Could you just remove the 'lev3: ' from the comment, pulling it in to
> > exactly 80 chars?  Your' added 'second level' and 'third level' make it
> > redundant, and I'd rather not lose the spaces in the comments.
> 
> I think that makes it exactly 80 characters, which is probably ok.

It ends up as below, exactly 80 characters long. I think it's probably
not worth it.

diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index 93f4edb..be09418 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -24,10 +24,14 @@
 
 #define ZIMAGE_MAGIC_NUMBER 0x016f2818
 
-#define PT_PT  0xe7f /* nG=1, AF=1, SH=10, AP=01, NS=1, ATTR=111, T=1, P=1 */
-#define PT_MEM 0xe7d /* nG=1, AF=1, SH=10, AP=01, NS=1, ATTR=111, T=0, P=1 */
-#define PT_DEV 0xe71 /* nG=1, AF=1, SH=10, AP=01, NS=1, ATTR=100, T=0, P=1 */
-#define PT_DEV_L3 0xe73 /* lev3: nG=1, AF=1, SH=10, AP=01, NS=1, ATTR=100, 
T=1, P=1 */
+#define PT_PT     0xe7f /* nG=1, AF=1, SH=10, AP=01, NS=1, ATTR=111, T=1, P=1 
*/
+
+/* Second Level */
+#define PT_MEM    0xe7d /* nG=1, AF=1, SH=10, AP=01, NS=1, ATTR=111, T=0, P=1 
*/
+#define PT_DEV    0xe71 /* nG=1, AF=1, SH=10, AP=01, NS=1, ATTR=100, T=0, P=1 
*/
+
+/* Third Level */
+#define PT_DEV_L3 0xe73 /* nG=1, AF=1, SH=10, AP=01, NS=1, ATTR=100, T=1, P=1 
*/
 
 #define PT_UPPER(x) (PT_##x & 0xf00)
 #define PT_LOWER(x) (PT_##x & 0x0ff)




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel