Re: [Xen-devel] [PATCH 02 of 15] libxl: Add LIBXL_SHUTDOWN_REASON_UNKNOWN

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-11-29 at 16:23 +0000, Rob Hoes wrote:
> > libxl: Add LIBXL_SHUTDOWN_REASON_UNKNOWN
> > 
> > libxl_dominfo.shutdown_reason is valid iff (shutdown||dying). This is a bit
> > annoying when generating language bindings since it needs all sorts of
> > special casing. Just introduce an explicit value instead.
> > 
> > Signed-off-by: Ian Campbell <ian.cambell@xxxxxxxxxx>
> 
> This change is very useful from an ocaml-bindings point of view.
> 
> Acked-by: Rob Hoes <rob.hoes@xxxxxxxxxx>

Thanks. I think I'm actually going to defer on applying this one until
we have a clearer idea what direction the bindings are taking.

In particular if we decide to implement the "default" state with
None/Some (see comment on patch 15/15) then that may be more appropriate
than this change.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel