Re: [Xen-devel] [PATCH] xen: arm: introduce arm32 as a subarch of arm.

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 19 Dec 2012, Ian Campbell wrote:
> On Tue, 2012-12-18 at 18:27 +0000, Stefano Stabellini wrote:
> > It would be nice to add to the description of the patch what you are
> > doing. Something along these lines:
> > 
> > - move gic.h to include/asm-arm/gic.h;
> > - move assembly files (entry.S, head.S, mode_switch.S, proc-ca15.S,
> > lib/*) to xen/arch/arm/arm32;
> > - move asm-offsets.c to xen/arch/arm/arm32;
> > - make the appropriate Makefile changes.
> > 
> > Other than that the patch is OK.
> 
> Is this ok:
> 
> xen: arm: introduce arm32 as a subarch of arm.
> 
> - move 32-bit specific files into subarch specific arm32 subdirectory.
> - move gic.h to xen/include/asm-arm (it is needed from both subarch
>   and generic code).
> - make the appropriate build and config file changes to support
>   XEN_TARGET_ARCH=arm32.
> 
> This prepares us for an eventual 64-bit subarch.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> 

that's OK

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel