[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3 of 3 V2] xl: SWITCH_FOREACH_OPT handles special options directly



On Tue, Dec 18, 2012 at 4:18 PM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> xl: SWITCH_FOREACH_OPT handles special options directly.
>
> This removes the need for the "case 0: case 2:" boilerplate in every
> main_foo() but at the expense of a return in a macro which I find
> (mildly) distasteful.
>
I tend not to like return in macros either, but, in this case, I think I
like it more than having to always put that "case 0: case 2:" thing
explicitly... So, FWIW, I'd keep this patch.

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
---------------------------------------------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.