Re: [Xen-devel] Resizing block devices live?

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Tue, Dec 18, 2012 at 02:06:56PM +0000, George Dunlap wrote:
> On Tue, Dec 18, 2012 at 1:58 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx>wrote:
> 
> > On Tue, 2012-12-18 at 13:52 +0000, George Dunlap wrote:
> > > One of the requests from the xenorg.uservoice.com page that had a
> > > moderate amount of interest was to allow block devices to be resized.
> > > There's a description here:
> > >
> > >
> > https://xenorg.uservoice.com/forums/172169-xen-development/suggestions/3140313-implement-block-device-resize
> > >
> > >
> > > I have no idea what this would take -- can anyone comment?
> >
> > Doesn't that already work? I thought this was patch in the PV block
> > drivers ages ago...
> >
> > Yes, http://wiki.xen.org/wiki/XenParavirtOps lists it under 2.6.36.
> >
> > Maybe this is a missing feature of (lib)xl vs xend?
> >
> 
> "xm help" doesn't show a "block-resize" command, nor does grepping through
> tools for "resize" turn up anything.
> 
> Would someone be willing to do some investigation into whether such a
> command is implemented in the protocol, and what it would take to get a "xm
> block-resize" command working?  (Not necessarily do it, but have an idea
> what probably needs to be done.)

Looking at the history it looks to be:

1fa73be6be65028a7543bba8f14474b42e064a1b which is


commit 1fa73be6be65028a7543bba8f14474b42e064a1b
Author: K. Y. Srinivasan <ksrinivasan@xxxxxxxxxx>
Date:   Thu Mar 11 13:42:26 2010 -0800

    xen/front: Propagate changed size of VBDs
    
    Support dynamic resizing of virtual block devices. This patch supports
    both file backed block devices as well as physical devices that can be
    dynamically resized on the host side.
    
    Signed-off-by: K. Y. Srinivasan <ksrinivasan@xxxxxxxxxx>
    Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 60006b7..f47b096 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -930,9 +930,24 @@ static void blkfront_connect(struct blkfront_info *info)
        unsigned int binfo;
        int err;
 
-       if ((info->connected == BLKIF_STATE_CONNECTED) ||
-           (info->connected == BLKIF_STATE_SUSPENDED) )
+       switch (info->connected) {
+       case BLKIF_STATE_CONNECTED:
+               /*
+                * Potentially, the back-end may be signalling
+                * a capacity change; update the capacity.
+                */
+               err = xenbus_scanf(XBT_NIL, info->xbdev->otherend,
+                                  "sectors", "%Lu", &sectors);
+               if (XENBUS_EXIST_ERR(err))
+                       return;
+               printk(KERN_INFO "Setting capacity to %Lu\n",
+                      sectors);
+               set_capacity(info->gd, sectors);
+
+               /* fall through */
+       case BLKIF_STATE_SUSPENDED:
                return;
+       }
 
        dev_dbg(&info->xbdev->dev, "%s:%s.\n",
                __func__, info->xbdev->otherend);

So it should be altering the 'sectors' value and just writting 
the backend state from XenbusStateConnected to XenbusStateConnected.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel