Re: [Xen-devel] [PATCH 10/11] nEPT: expost EPT capablity to L1 VMM

[Tim Deegan <tim@xxxxxxx>]

At 01:57 +0800 on 11 Dec (1355191042), xiantao.zhang@xxxxxxxxx wrote:
> --- a/xen/arch/x86/mm/hap/nested_ept.c
> +++ b/xen/arch/x86/mm/hap/nested_ept.c
> @@ -48,7 +48,7 @@
>  #define EPT_EMT_WB  6
>  #define EPT_EMT_UC  0
>  
> -#define NEPT_VPID_CAP_BITS 0
> +#define NEPT_VPID_CAP_BITS 0x0000000006134140ul

Ah, I didn't spot this earlier.  I think for clarity the definition of
nept_get_ept_vpid_cap() should be moved entirely into this faile (and
presuambly the TODO comment can be removed).

Where does the magic number 0x0000000006134140ul come from?
Can it be broken out into meaningful constants?

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel