[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools: use PREFIX when building upstream qemu



On 13.12.12 11:40, Ian Campbell wrote:

Adding Christoph's new address, I guess this is a thing exposed on
NetBSD?


This is not specific to NetBSD. It is exposed everywhere where you
install Xen into a non-default directory by specifying the prefix
to configure.

Christoph


On Thu, 2012-10-25 at 13:39 +0100, Ian Jackson wrote:
Christoph Egger writes ("[Xen-devel] [PATCH] tools: use PREFIX when building 
upstream qemu"):

use PREFIX when building upstream qemu.

Signed-off-by: Christoph Egger<Christoph.Egger@xxxxxxx>

This looks reasonable but can you explain what goes wrong when,
without this ?  I'd like to be able to verify the bug and fix myself.

AFAICT the default PREFIX for qemu-xen is /usr/local and we pass
--bindir, --datadir (as Xen specific paths, like /usr/lib/xen/bin) but
not --prefix. It looks like this covers most stuff but results in a
smattering of stuff getting installed under /usr/local:

$ find dist/install/usr/local/ | grep qemu
dist/install/usr/local/libexec/qemu-bridge-helper
dist/install/usr/local/share/man/man8/qemu-nbd.8
dist/install/usr/local/share/man/man1/qemu.1
dist/install/usr/local/share/man/man1/qemu-img.1
dist/install/usr/local/share/doc/qemu
dist/install/usr/local/share/doc/qemu/qemu-tech.html
dist/install/usr/local/share/doc/qemu/qemu-doc.html
dist/install/usr/local/share/doc/qemu/qmp-commands.txt
dist/install/usr/local/etc/qemu
dist/install/usr/local/etc/qemu/target-x86_64.conf
(there is also some ocaml stuff under there it seems...)

I'm not quite sure that installing those into our $PREFIX is correct
either though -- there seems like the possibility of clashing with a
non-Xen install of qemu, so we might be better off moving these to e.g.
$PREFIX/doc/xen/qemu/ and adding "xen" in the man page path etc? (the
binaries corresponding to those manpages are in /usr/lib/xen/bin/)
Perhaps qemu.1xen ?

I don't know what dist/install/usr/local/etc/qemu/target-x86_64.conf is
but it is empty here. I suspect Xen does not use
dist/install/usr/local/libexec/qemu-bridge-helper or it should be
in /usr/lib/xen/bin.

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.