Re: [Xen-devel] [PATCH V5] x86/kexec: Change NMI and MCE handling on kexec path

[Tim Deegan <tim@xxxxxxx>]

At 11:47 +0000 on 13 Dec (1355399235), Andrew Cooper wrote:
> >nmi_shootdown_cpus() has a go, but I think it would have to do an atomic
> >compare-exchange on crashing_cpu to actually be sure that only one CPU
> >is crashing at a time.  If two CPUs try to lead crashes at the same
> >time, it will deadlock here, with NMIs disabled on all CPUs.
> 
> kexec_common_shutdown() calls one_cpu_only() which gives the impression 
> that nmi_shootdown_cpus() can only be gotten to once.

Right, I missed that.  So,

Acked-by: Tim Deegan <tim@xxxxxxx>

You can tidy up entry.S or not, as you like.  There's no correctness
issue with anything there, just things that could be neater if you were
already updating the patch.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel