Re: [Xen-devel] [PATCH v2 3/8] xen: introduce a generic framebuffer driver

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-12-10 at 17:51 +0000, Stefano Stabellini wrote:

[snip, 300 lines of unnecessarily quoted material, come on guys!]

> > > +void fb_cr(void);
> > 
> > Please make this fb_create() or alike - "cr" alone could well be
> > mistaken as "carriage return".

Or control register which was my first thought.

> Actually it is supposed to be "cr": it is used by vesa_endboot to reset
> the cursor to column 0.

fb_carriage_return? It's not called so frequently that a little extra
typing will hurt.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel