Re: [Xen-devel] [PATCH 14/14] stubdom/Makefile: Fix gmp extract rule

[Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>]

On 12/10/2012 04:24 PM, Samuel Thibault wrote:
> Daniel De Graaf, le Mon 10 Dec 2012 14:55:47 -0500, a écrit :
>>  gmp-$(XEN_TARGET_ARCH): gmp-$(GMP_VERSION).tar.bz2 $(NEWLIB_STAMPFILE)
>>      tar xjf $<
>> +    rm $@ -rf || :
> 
> I'm realizing...
> 
>>      mv gmp-$(GMP_VERSION) $@
>>      #patch -d $@ -p0 < gmp.patch
>>      cd $@; CPPFLAGS="-isystem 
>> $(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf/include $(TARGET_CPPFLAGS)" 
>> CFLAGS="$(TARGET_CFLAGS)" CC=$(CC) $(GMPEXT) ./configure --disable-shared 
>> --enable-static --disable-fft --without-readline 
>> --prefix=$(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf
> 
> Which is configure invoked here?  In the other cases, we have used a
> stampfile, to separate unpacking and configure stages, which avoids the
> issue.  Is it because libgmp does not support build out of tree?  If so,
> then I'm fine with the rm change, although -rm $@ -rf instead of || :
> would be more readable.
> 
> Samuel
> 

I didn't look too closely at the reasons why the configure is done here; the
rm is needed regardless of where the configure is done, assuming the tarball
could be touched while the directory exists.

I chose "|| :" instead of -rm because it silences make's output on the failure,
which will be normal the first time it is run. If -rm is preferred, that's
trivial to fix.

-- 
Daniel De Graaf
National Security Agency

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel