[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 4/6] xen/vesa: use the new fb_* functions
On Thu, 6 Dec 2012, Ian Campbell wrote: > On Thu, 2012-12-06 at 11:28 +0000, Jan Beulich wrote: > > >>> On 05.12.12 at 19:19, Stefano Stabellini > > >>> <stefano.stabellini@xxxxxxxxxxxxx> > > wrote: > > > Make use of the framebuffer functions previously introduced. > > > > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> > > > > Conceptually this and the prior patch look fine, but the one here > > definitely is against a stale tree (namely lacking the merge with > > 26184:7b4449bdb980). > > Need to be careful with the code motion then, from that PoV these two > patches would be better combined. That is true. If you prefer I can merge the two patches. > Also, this vmap/ioremap thing seems like something we should replicate > on ARM instead of the map_phys_range introduced in a previous patch > (even if it is just a name change). No reason to gratuitously differ on > these things. Of course we should have ioremap working on ARM, however in this case I would rather not use ioremap, because in its current form relies on the xen domheap being already setup, while I would prefer being able to initialize the HDLCD controller earlier than that. On the other hand we could have a much simpler implementation of ioremap only based on map_phys_range rather than vmap. I wouldn't be against that. We could call it early_ioremap to make it clear that it differs from the x86 counterpart. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |