Re: [Xen-devel] [VTPM v5 7/7] Add a real top level configure script that calls the others

[Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>]

On 11/30/2012 06:57 AM, Ian Campbell wrote:
> On Thu, 2012-11-29 at 17:35 +0000, Matthew Fioravante wrote:
> > Signed-off-by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> > ---
> >   autogen.sh         |    1 +
> >   configure          | 3013 +++++++++++++++++++++++++++++++++++++++++++++++++++-
> Pretty impressive for a minimal configure.ac ;-)
>
> >   configure.ac       |   14 +
> >   tools/configure    |  601 ++++++-----
> >   tools/configure.ac |    2 +-
> >   5 files changed, 3341 insertions(+), 290 deletions(-)
> >   create mode 100644 configure.ac
> > diff --git a/configure.ac b/configure.ac
> > new file mode 100644
> > index 0000000..3a6339c
> > --- /dev/null
> > +++ b/configure.ac
> > @@ -0,0 +1,14 @@
> > +#                                               -*- Autoconf -*-
> > +# Process this file with autoconf to produce a configure script.
> > +
> > +AC_PREREQ([2.67])
> > +AC_INIT([Xen Hypervisor], m4_esyscmd([./version.sh ./xen/Makefile]),
> > +    [xen-devel@xxxxxxxxxxxxx], [xen], [http://www.xen.org/])
> > +AC_CONFIG_SRCDIR([./tools/libxl/libxl.c])
> > +AC_CONFIG_FILES([./config/Tools.mk])
> If I understand correctly this causes this script to consider
> config/Tools.mk as an output file, which it isn't for this script (that
> is tools/configure's job).
Yeah thats a typo, will be removed
> If this is needed then why is config/Stubdom.mk similarly listed?
>
> > +AC_PREFIX_DEFAULT([/usr])
> > +AC_CONFIG_AUX_DIR([.])
> Looking at
> http://www.gnu.org/software/automake/manual/html_node/Optional.html I
> wonder if we shouldn't also change the sub-configures to use .. with
> this macro, such that they pickup the toplevel config.{sub,guess} etc
> which this implies instead of having their own copy?
>
> Since the default is ., .. or ../.. do we need this at all?
I'll test this, we have multiple copies of install-sh now so removing 
this means we can probably go back to just 1.
> > +
> > +AC_CONFIG_SUBDIRS([tools stubdom])
> > +
> > +AC_OUTPUT()
> Is this mandatory? This configure script shouldn't have any output other
> than the call to the sub-configures.
The configure script does nothing without AC_OUTPUT. It doesn't call the 
other scripts so I think we need this.
> [...]
> > diff --git a/tools/configure.ac b/tools/configure.ac
> > index 971e3e9..9924852 100644
> > --- a/tools/configure.ac
> > +++ b/tools/configure.ac
> > @@ -2,7 +2,7 @@
> >   # Process this file with autoconf to produce a configure script.
> >
> >   AC_PREREQ([2.67])
> > -AC_INIT([Xen Hypervisor], m4_esyscmd([../version.sh ../xen/Makefile]),
> > +AC_INIT([Xen Hypervisor Tools], m4_esyscmd([../version.sh ../xen/Makefile]),
> >       [xen-devel@xxxxxxxxxxxxx], [xen], [http://www.xen.org/])
> >   AC_CONFIG_SRCDIR([libxl/libxl.c])
> >   AC_CONFIG_FILES([../config/Tools.mk])
> > --
> > 1.7.10.4

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel