[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1 of 4 v2] libxl: Combine device model arg build functions
This patch also provides an easy way to trigger an interesting "failure to handle failure" bug in libxl. To reproduce: * Apply *only* this patch, and not patch 2 in this series (which filters it out at the xl level) * Create a config file where vnclisten has a display number, and vncdisplay is non-zero; e.g.: vnclisten="0.0.0.0:1" vncdisplay=1 (vncdisplay=0 is indistinguishable, to xl, from not having it set at all.) The result is a set of error messages like this: libxl: error: libxl_dm.c:231:libxl__build_device_model_args: vncdisplay set, but vnclisten also contains adisplay number Too confused to continue. libxl: error: libxl_dm.c:1113:device_model_spawn_outcome: (null): spawn failed (rc=-3) libxl: error: libxl_exec.c:118:libxl_report_child_exitstatus: /etc/xen/scripts/vif-bridge add [21168] exited with error status 1 libxl: error: libxl_create.c:1117:domcreate_attach_vtpms: unable to add nic devices libxl: error: libxl_dm.c:1140:libxl__destroy_device_model: could not find device-model's pid for dom 25 libxl: error: libxl.c:1414:libxl__destroy_domid: libxl__destroy_device_model failed for 25 Obviously the failure in libxl__build_device_model_args() failed to abort the domain-building process, and it continued to try to run vif and vtpm setups. -George On Fri, Nov 30, 2012 at 4:24 PM, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote: # HG changeset patch _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |