Re: [Xen-devel] [PATCH] xen: get GIC addresses from DT

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 30 Nov 2012, David Vrabel wrote:
> >>> +    cell = (const u32 *)prop->data;
> >>> +    device_tree_get_reg(&cell, address_cells, size_cells, &start, &size);
> >>
> >> Is this needed?  This cell is reread below.
> > 
> > Yes, because device_tree_get_reg increments the cell pointer
> 
> Perhaps I wasn't clear.  The result of this device_tree_get_reg() is not
> used anywhere, and the side effect of advancing cell is also not used.

You are right, I am not sure how it ended up there, I'll remove those
two lines.
Thanks!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel