Re: [Xen-devel] [PATCH 08/12] device-tree: get_val cannot cope with cells > 2, add a BUG

[Tim Deegan <tim@xxxxxxx>]

At 16:23 +0000 on 13 Nov (1352823800), Ian Campbell wrote:
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
> v2: drop unrelated white space fixup
> ---
>  xen/common/device_tree.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index efd1663..7d3fd9f 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -45,6 +45,8 @@ static void __init get_val(const u32 **cell, u32 cells, u64 
> *val)
>  {
>      *val = 0;
>  
> +    BUG_ON( cells > 2 );
> +

If this is caused by a malformed DTB (rather than a Xen bug), I think
this should be an early_panic() or similar.

>      while ( cells-- )
>      {
>          *val <<= 32;
> -- 
> 1.7.9.1
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel