Re: [Xen-devel] [PATCH 2 of 5 RFC] blktap3: Logging for the xenio daemon and libxenio

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-11-28 at 14:20 +0000, Thanos Makatos wrote:
> This patch introduces xenio and libxenio logging functionality. At the moment
> logging is passed to vsyslog() via a wrapper.

This is a rather fine grained way to present these patches. A single
patch "add the xenio daemon" would have been ok I think.

> 
> diff -r d426fc267197 -r 6918a76c96d8 tools/blktap3/xenio/log.c
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/tools/blktap3/xenio/log.c       Wed Nov 28 14:13:29 2012 +0000
> @@ -0,0 +1,15 @@
> +#include "compiler.h"
> +#include <stdarg.h>
> +#include <syslog.h>
> +
> +void (*xenio_vlog) (int prio, const char *fmt, va_list ap) = vsyslog;
> +
> +__printf(2, 3) void
> +xenio_log(int prio, const char *fmt, ...)
> +{
> +    va_list ap;
> +    va_start(ap, fmt);
> +    xenio_vlog(prio, fmt, ap);
> +    va_end(ap);
> +}
> +
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel