Re: [Xen-devel] Patches for v3.8

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Thu, Nov 29, 2012 at 11:51:27AM +0000, Ian Campbell wrote:
> On Wed, 2012-11-28 at 16:00 +0000, Ian Campbell wrote:
> > I'll take a look over the next couple of days.
> 
> Just looking into this now and in
> konrad/stable/pvh.v6:arch/x86/xen/mmu.c in xen_remap_domain_mfn_range we
> have:
> 
> 
>       if (xen_feature(XENFEAT_auto_translated_physmap))
>               return -EINVAL;
> 
> ...
> 
>       if (xen_feature(XENFEAT_auto_translated_physmap)) {
>               /* We need to update the local page tables and the xen HAP */
>               return pvh_remap_gmfn_range(vma, addr, mfn, nr, prot, domid, 
> pages);
>       }
> 
> So it seems like the second one will never be reached...

Yikes! I wonder if I did a mismerge/rebase incorrectly? Mukesh, do you
recall if the original patchset had the first check removed?

> 
> AFAICT this was already the case when support was added in
> de81067d4ef5b434b47f63e11448b3b09cfc0b5e.
> 
> Ian.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel