Re: [Xen-devel] [PATCH] x86/hap: Fix memory leak of domain->arch.hvm_domain.dirty_vram

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.11.12 at 12:05, Tim Deegan <tim@xxxxxxx> wrote:
> At 07:26 +0000 on 29 Nov (1354174019), Jan Beulich wrote:
>> >>> On 29.11.12 at 02:00, Kouya Shimura <kouya@xxxxxxxxxxxxxx> wrote:
>> > On 11/28/2012 05:39 PM, Jan Beulich wrote:
>> >>>>> On 28.11.12 at 07:51, Kouya Shimura <kouya@xxxxxxxxxxxxxx> wrote:
>> >>> This patch fixes the memory leak of domain->arch.hvm_domain.dirty_vram.
>> >>>
>> >>> Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>
>> >>
>> >> Wouldn't it be more consistent (and less redundant) to do this
>> >> through calling hap_track_dirty_vram(d, 0, 0, ...)? And even if
>> >> not, the conditional around the freeing/clearing is pointless.
>> > 
>> >  From another point of view, it's consistent since it almost
>> > copied from shadow_teardown()@xen/arch/x86/mm/shadow/common.c.
>> > That is a sibling function of hap_teardown().
>> > If it's not preferable, another cleanup patch should be made.
>> 
>> Tim will have the final say here anyway.
> 
> I have taken the conditional out but left it as an explicit free(). 
> It might not always be safe to call hap_track_dirty_vram(), even for
> disabling, this late in the teardown.

So is this something we also want to have on 4.2 and 4.1?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel