[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH VTPM v4 3/5] vtpm/vtpmmgr and required libs to stubdom/Makefile
Ian Campbell writes ("Re: [PATCH VTPM v4 3/5] vtpm/vtpmmgr and required libs to stubdom/Makefile"): > On Tue, 2012-11-20 at 14:21 +0000, Matthew Fioravante wrote: > > +tpm_emulator-$(XEN_TARGET_ARCH): tpm_emulator-$(TPMEMU_VERSION).tar.gz > > + tar xzf $< > > + mv tpm_emulator-$(TPMEMU_VERSION) $@ > > + patch -d $@ -p1 < tpmemu-$(TPMEMU_VERSION).patch; > > + mkdir $@/build > > + cd $@/build; cmake .. -DCMAKE_C_COMPILER=${CC} > > -DCMAKE_C_FLAGS="-std=c99 -DTPM_NO_EXTERN $(TARGET_CPPFLAGS) > > $(TARGET_CFLAGS) -Wno-declaration-after-statement" > > + touch $@ > > Ian -- is the test system ready to copy with this cmake requirement? > > Or do we need to make this dependency conditional? I think it would be better to make the dependency conditional. Ideally this would be done via configure but (having discussed this with Ian Campbell) we think converting stubdom to use autoconf is too much yak-shaving to ask of you. I guess it would be possible to have an ad-hoc switch in Config.mk (say) but I'm not sure this is better than just adding cmake as a hard dependency. So I have pushed a change to the pre-test tree for the automatic testing system to add cmake to the set of packages installed for builds. Barring unrelated trouble, this should pass the self-tests and be live by tomorrow morning. > I think at the very least it should be $(CMAKE), at which point we may > as well go the whole hog and make configure.ac do the right thing. I think it's fine to say CMAKE:=cmake somewhere. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |