Re: [Xen-devel] [PATCH 2 of 2] xl: Accept a list for usbdevice in config file

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-11-28 at 16:52 +0000, George Dunlap wrote:
> On Wed, Nov 28, 2012 at 3:11 PM, Pasi KÃrkkÃinen <pasik@xxxxxx> wrote:
>         On Wed, Nov 28, 2012 at 12:16:06PM +0000, George Dunlap wrote:
>         > # HG changeset patch
>         > # User George Dunlap <george.dunlap@xxxxxxxxxxxxx>
>         > # Date 1354104851 0
>         > # Node ID e87d8fad28e00090591b65b2682dea9112f8830d
>         > # Parent  538d9ffbd71b41e8cf6d7da0ded9e0a0b07f3c0d
>         > xl: Accept a list for usbdevice in config file
>         >
>         > Allow the "usbdevice" key to accept a list of USB devices,
>         and pass
>         > them in using the new usbdevice_list domain build element.
>         >
>         > For backwards compatibility, still accept singleton values.
>         >
>         > Also update the xl.cfg manpage, adding information about how
>         to pass
>         > through host devices.
>         >
>         > Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
>         >
>         > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
>         > --- a/docs/man/xl.cfg.pod.5
>         > +++ b/docs/man/xl.cfg.pod.5
>         > @@ -1103,15 +1103,22 @@ device.
>         >
>         >  Enables or disables a USB bus in the guest.
>         >
>         
>         
>         Should we add "HVM" there ?
> 
> I could make this say, "...in an HVM guest".  (I'll wait to see if I
> get other comments before re-sending the patch.)

FWIW other similar options simply begin the paragraph with "(HVM only)"

But actually this particular option is already underneath a section
which begins "The following options apply only to HVM guests." and we
don't seem to reiterate that in the other options.

>         > -=item B<usbdevice=DEVICE>
>         > +=item B<usbdevice=[ "DEVICE", "DEVICE", ...]>
>         >
>         > -Adds B<DEVICE> to the USB bus. The USB bus must also be
>         enabled using
>         > -B<usb=1>. The most common use for this option is
>         B<usbdevice=tablet>

Are there other non-host* options?

> I think this level of detail is probably too high for a man page --
> this kind of thing should be on a wiki somewhere I think.

Its a bit of a cop-out but we do reference qemu(1) in some other places,
which might suffice here?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel