[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH RFC] stubdom: Change vTPM shared page ABI
On 11/28/2012 03:46 PM, Konrad Rzeszutek Wilk wrote: I've already done that with my patch on the linux mailing list. The old frontend driver name was tpm_xenu.ko, the new one is xen-tpmfront.ko.On Fri, Nov 23, 2012 at 11:04:06AM +0000, Ian Campbell wrote:On Tue, 2012-11-20 at 16:16 +0000, Fioravante, Matthew E. wrote:This was something I've been wanting to do for a while so I'm very happy you went ahead and fixed it yourself. Once you submit the linux version I'll test it on my system. Acked by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>Do we need to synchronise with anything else (Linux drivers?) or I can I just throw this into the tree once it is done? Are we hanging any existing users of the tpm stuff out to dry? Could we get a feature-protocol-v2 flag in xenstore so users at least get an error message from either the front or backend to give a hint why it isn't working?We could cop out and just name this new driver differently. Then we would not have to deal with the older ones. void send_response(tpmcmd_t* cmd, tpmif_t* tpmif) { - tpmif_tx_request_t* tx; - int offset; - int i; - uint32_t domid; - int tocopy; + vtpm_shared_page_t* shr; + unsigned int offset; int flags; +#ifdef TPMBACK_PRINT_DEBUG +int i; +#endifDodgy indentation? (I saw a bunch of these)- * Copyright (c) 2005, IBM Corporation - * - * Author: Stefan Berger, stefanb@xxxxxxxxxx - * Grant table support: Mahadevan GomathisankaranDid you really remove everything these guys wrote?- * This code has been derived from tools/libxc/xen/io/netif.h - * - * Copyright (c) 2003-2004, Keir FraserI guess I can buy this bit no longer being true given that you reworked the whole protocol. Ian _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel Attachment:
smime.p7s _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |