[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] IOMMU: imply "verbose" from "debug"


  • To: "xen-devel" <xen-devel@xxxxxxxxxxxxx>
  • From: "Jan Beulich" <JBeulich@xxxxxxxx>
  • Date: Wed, 28 Nov 2012 14:33:02 +0000
  • Delivery-date: Wed, 28 Nov 2012 14:32:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

I think that generally enabling debugging code without also enabling
verbose output is rather pointless; if someone really wants this, they
can always pass e.g. "iommu=debug,no-verbose".

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -92,7 +92,11 @@ static void __init parse_iommu_param(cha
         else if ( !strcmp(s, "intremap") )
             iommu_intremap = val;
         else if ( !strcmp(s, "debug") )
+        {
             iommu_debug = val;
+            if ( val )
+                iommu_verbose = 1;
+        }
         else if ( !strcmp(s, "amd-iommu-perdev-intremap") )
             amd_iommu_perdev_intremap = val;
         else if ( !strcmp(s, "dom0-passthrough") )



Attachment: IOMMU-debug-verbose.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.