Re: [Xen-devel] [PATCH 1/4] stubdom: Change vTPM shared page ABI

[Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>]

On 11/27/2012 04:29 PM, Matthew Fioravante wrote:
> I can't get this patch to apply. It looks like your editor or something else 
> is converting tabs to whitespace. For instance the line in tpmback.h
> 
>     domid_t domid;              /* Domid of the frontend */
> 
> has tabs between domid; and /*. It looks like this also happened to your 
> linux patch.

The problem looks like it's on your end; my patch has a tab character there,
and it shows up with a tab character in my copy of the xen-devel list.

As a quick workaround, I have pushed these patches to my github repository:
https://github.com/danieldg/xen-unstable/commits/vtpm

> 
> On 11/27/2012 10:14 AM, Daniel De Graaf wrote:
>> This changes the vTPM shared page ABI from a copy of the Xen network
>> interface to a single-page interface that better reflects the expected
>> behavior of a TPM: only a single request packet can be sent at any given
>> time, and every packet sent generates a single response packet. This
>> protocol change should also increase efficiency as it avoids mapping and
>> unmapping grants when possible.
>>
>> Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
>> ---
>>   extras/mini-os/include/tpmback.h  |   1 +
>>   extras/mini-os/include/tpmfront.h |   7 +-
>>   extras/mini-os/tpmback.c          | 159 
>> +++++++++++++++++++------------------
>>   extras/mini-os/tpmfront.c         | 162 
>> ++++++++++++++++++++++----------------
>>   xen/include/public/io/tpmif.h     |  45 +++--------
>>   5 files changed, 191 insertions(+), 183 deletions(-)
>>
>> diff --git a/extras/mini-os/include/tpmback.h 
>> b/extras/mini-os/include/tpmback.h
>> index ff86732..ec9eda4 100644
>> --- a/extras/mini-os/include/tpmback.h
>> +++ b/extras/mini-os/include/tpmback.h
>> @@ -43,6 +43,7 @@
>>
>>   struct tpmcmd {
>>      domid_t domid;              /* Domid of the frontend */
>> +   uint8_t locality;    /* Locality requested by the frontend */
>>      unsigned int handle;        /* Handle of the frontend */
>>      unsigned char uuid[16];                     /* uuid of the tpm 
>> interface */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel