Re: [Xen-devel] [PATCH] libxl: Fix bug in libxl_cdrom_insert, make more robust against bad xenstore data

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-11-23 at 11:37 +0000, George Dunlap wrote:

> I would have returned an error, but the fuction returns void.  :-)
> That leaves us the options of:
> 1. Erroring and calling exit() in the middle of the function
> 2. Just doing a warning
> 3. Modifying the function to return success / failure
> 
> #3 seems like the it shouldn't be too very difficult.

Yes, it looks like both the callers should manage to do something sane
pretty easily.

>   If that sounds good to you I'll re-post this patch with only the
> bits you've acked, then post another patch with #3.

Sounds good.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel