Re: [Xen-devel] [PATCH] xend: enable environment passing in xPopen3

[Olaf Hering <olaf@xxxxxxxxx>]

On Fri, Nov 23, Ian Campbell wrote:

> On Wed, 2012-11-21 at 20:49 +0000, Olaf Hering wrote:
> > # HG changeset patch
> > # User Olaf Hering <olaf@xxxxxxxxx>
> > # Date 1353530937 -3600
> > # Node ID a446956472330fe32bc69be764a33f59fb090792
> > # Parent  2489c29266982175b5b4e945c97b4549360e947f
> > xend: enable environment passing in xPopen3
> > 
> > In changeset 19990:38dd208e1d95 a new parameter 'env' was added to
> > xPopen3, but no code was added to actually pass the environment down to
> > execvpe. Also, the new code was unreachable.
> > 
> > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> 
> It seems that no callers provide an environment? How did you spot this?

In my testing I did pass options to xc_save via the environment, which
is called via forkhelper (somewhere in python code).

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel