Re: [Xen-devel] [PATCH V2]xenstore-chmod: handle arbitrary number of perms rather than MAX_PERMS constant

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-11-20 at 02:59 +0000, Chunyan Liu wrote:
> Constant MAX_PERMS 16 is too small to use in some occasions, e.g. if
> there are more than 16 domU(s) on one hypervisor (it's easy to
> achieve) and one wants to do xenstore-chmod PATH to all domU(s). So,
> remove MAX_PERMS limitation and make it as arbitrary number of perms.
> 
> Signed-off-by: Chunyan Liu <cyliu@xxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Unfortunately the patch is whitespace damaged and therefore doesn't
apply. There are some stray hard tabs in the source which have turned
into soft tabs in your mail.

http://wiki.xen.org/wiki/Submitting_Xen_Patches has some hints on using
hg patchbomb to avoid this, and also a link to Linux's email-client.txt
which has hints on how to avoid whitespace mangling with various
clients.

BTW, I'd be happy for you to cleanup the hard tabs in lines which you
are touching anyway, but they need to be present in the "-" line for the
patch to apply of course.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel