Re: [Xen-devel] [PATCH v2 01/11] kexec: introduce kexec_ops struct

[ebiederm@xxxxxxxxxxxx (Eric W. Biederman)]

Daniel Kiper <daniel.kiper@xxxxxxxxxx> writes:

> Some kexec/kdump implementations (e.g. Xen PVOPS) could not use default
> functions or require some changes in behavior of kexec/kdump generic code.
> To cope with that problem kexec_ops struct was introduced. It allows
> a developer to replace all or some functions and control some
> functionality of kexec/kdump generic code.
>
> Default behavior of kexec/kdump generic code is not changed.

Ick.

> v2 - suggestions/fixes:
>    - add comment for kexec_ops.crash_alloc_temp_store member
>      (suggested by Konrad Rzeszutek Wilk),
>    - simplify kexec_ops usage
>      (suggested by Konrad Rzeszutek Wilk).
>
> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> ---
>  include/linux/kexec.h |   26 ++++++++++
>  kernel/kexec.c        |  131 
> +++++++++++++++++++++++++++++++++++++------------
>  2 files changed, 125 insertions(+), 32 deletions(-)
>
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index d0b8458..c8d0b35 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -116,7 +116,33 @@ struct kimage {
>  #endif
>  };
>  
> +struct kexec_ops {
> +     /*
> +      * Some kdump implementations (e.g. Xen PVOPS dom0) could not access
> +      * directly crash kernel memory area. In this situation they must
> +      * allocate memory outside of it and later move contents from temporary
> +      * storage to final resting places (usualy done by relocate_kernel()).
> +      * Such behavior could be enforced by setting
> +      * crash_alloc_temp_store member to true.
> +      */

Why in the world would Xen not be able to access crash kernel memory?
As currently defined it is normal memory that the kernel chooses not to
use.

If relocate kernel can access that memory you definitely can access the
memory so the comment does not make any sense.

> +     bool crash_alloc_temp_store;
> +     struct page *(*kimage_alloc_pages)(gfp_t gfp_mask,
> +                                             unsigned int order,
> +                                             unsigned long limit);
> +     void (*kimage_free_pages)(struct page *page);
> +     unsigned long (*page_to_pfn)(struct page *page);
> +     struct page *(*pfn_to_page)(unsigned long pfn);
> +     unsigned long (*virt_to_phys)(volatile void *address);
> +     void *(*phys_to_virt)(unsigned long address);
> +     int (*machine_kexec_prepare)(struct kimage *image);
> +     int (*machine_kexec_load)(struct kimage *image);
> +     void (*machine_kexec_cleanup)(struct kimage *image);
> +     void (*machine_kexec_unload)(struct kimage *image);
> +     void (*machine_kexec_shutdown)(void);
> +     void (*machine_kexec)(struct kimage *image);
> +};

Ugh.  This is a nasty abstraction.

You are mixing and matching a bunch of things together here.

If you need to override machine_kexec_xxx please do that on a per
architecture basis.

Special case overrides of page_to_pfn, pfn_to_page, virt_to_phys,
phys_to_virt, and friends seem completely inappropriate.

There may be a point to all of these but you are mixing and matching
things badly.


Eric

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel