[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xl: Suppress spurious warning message for cpupool-list

On Fri, Aug 17, 2012 at 9:21 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> This patch adds a "probe" argument to cpupool_info(). If set, it won't print
> a warning if the xc_cpupool_getinfo() fails with ENOENT.

Looking at the callers I think the existing "exact" parameter could be
used instead of a new param -- it would be fine to fail silently on
ENOENT iff !exact, I think.

Hmm -- those two don't seem to me to necessarily mean the same thing; it's not clear to me that "exact==true" would imply "print an error message" and "exact==false" would imply "don't print an error message".

But at the moment the two callers of the function pass (true,false) and (false,true) for those booleans, and it is an internal function, so if it turns out we need to make a distinction we can always add the extra parameter in later.

New patch on the way...

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.