Re: [Xen-devel] [RFC/PATCH v5 1/2] hypervisor: XENMEM_claim_pages (subop of existing) hypercall

[Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>]

> From: Matthew Daley [mailto:mattjd@xxxxxxxxx]
> Subject: Re: [Xen-devel] [RFC/PATCH v5 1/2] hypervisor: XENMEM_claim_pages 
> (subop of existing)
> hypercall
> 
> On Tue, Nov 20, 2012 at 10:27 AM, Dan Magenheimer
> <dan.magenheimer@xxxxxxxxxx> wrote:
> > @@ -680,7 +680,7 @@ static int page_make_private(struct domain *d, struct 
> > page_info *page)
> >      ASSERT(page_get_owner(page) == dom_cow);
> >      page_set_owner(page, d);
> >
> > -    if ( d->tot_pages++ == 0 )
> > +    if ( domain_increase_tot_pages(d, 1) == 0 )
> 
> Here, the pre-incremented value of tot_pages is expected to be used in
> the expression..

Hmmm... yes, good catch (both places)!  v6 coming soon :-(

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel