Re: [Xen-devel] [RFC/PATCH v2] XENMEM_claim_pages (subop of existing) hypercall

[Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>]

> From: Andres Lagar-Cavilla [mailto:andreslc@xxxxxxxxxxxxxx]
> Subject: Re: [RFC/PATCH v2] XENMEM_claim_pages (subop of existing) hypercall
> 
> > Ideally, allocation in the presence of existing claims should
> > behave as if the claiming domains had actually already allocated
> > the unclaimed-amount-of-memory.  So I'd argue that enforcing
> > the claim should be sacrosanct here.
> 
> Well, are we sure that failing an "anonymous" allocations is not going to 
> trigger a BUG_ON? That's a
> lot of code review. If you get this wrong, now Xen suddenly crashes if 
> allocating domains close to the
> max. It doesn't, today, afaict.

I'm not sure I understand your concern.  What I said is
that the behavior is the same whether the memory is
allocated for a domain (the pre-claim way) or claimed
and then allocated later.  Claim is neither improving
a low-memory situation or making it worse.  If Xen
crashes when a claim has been staked (but not yet
satisfied), it would crash the same if the memory
had already been fully allocated.

> >> Similarly, but perhaps of lower priority, there is no integration
> >> with the low-mem handling.
> >
> > I'd also consider this lower priority as Olaf and Andre
> > have argued that the claim mechanism is not needed for
> > sharing/paging so the two mechanisms may not
> > be used together, at least for the foreseeable future.
> > So I plan to skip this, unless you change your mind and
> > consider it a showstopper for acceptance.
> 
> This is a slippery slope. Let's not work out the interactions with existing 
> subsystems before adding
> code to the tree. What could go wrong?

Indeed.

> As a data point for everyone, I've found the low men virq extremely useful as 
> a sync interrupt
> signaling to our toolstack that it needs to get its act together and start 
> rebalancing memory, if it
> hasn't yet. I don't see how that cannot be useful to any other toolstack.

Um... very different toolstack paradigm.

Besides (can't resist), in your toolstack, the toolstack is
omniscient about all hypervisor memory allocations, so why
would it _need_ to be notified? ;-) ;-) ;-) ;-) /me ducks

Dan "who holds out single daisy to Andre, previously withdrawn from George
in http://lists.xen.org/archives/html/xen-devel/2012-11/msg00150.html";

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel