[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] Fix locking in tools/hotplug/Linux/locking.sh
On Tue, 2012-11-13 at 16:21 +0000, Ian Jackson wrote: > Jacek Konieczny writes ("Re: [Xen-devel] [PATCH] Fix locking in > tools/hotplug/Linux/locking.sh"): > > fcntl(3, F_GETFL) = 0x8401 (flags > > O_WRONLY|O_APPEND|O_LARGEFILE) > > So it seems perl is going out of its way to spot this earlier. > That explains the mystery. Looking at glibc it seems like it has had this test since the mid-nineties, so quite why we aren't seeing it elsewhere I can't explain (maybe bash buggily opens the fd RDWR?) > Anyway the patch is fine. > > Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Yes, irrespective of why this patch does seem to be correct: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |