Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Thu, Nov 08, 2012 at 09:46:16AM +0100, Ian Campbell wrote:
> > > >>+typedef struct tpmif_tx_request tpmif_tx_request_t;
> > > >   checkpatch warned on this new typedef - please run through checkpatch
> > > >and fix up that stuff.
> > > tpmif.h has a couple of typedefs which do trigger checkpatch
> > > warnings. However it looks like the paradigm for xen is to have
> > > these interface/io/<dev>if.h files and all of them have typedefs. I
> > > think in this case the typedef should probably stay.
> > > 
> > > Konrad your thoughts here?
> > 
> > Rip them out plea
> 
> This is somewhere that Linux coding style and Xen coding style differ,
> so the typedefs should be removed from the Linux copy of these
> interfaces to match the Linux coding style, but they should stay in the
> Xen side canonical copy though.

Yes. Sorry for not making that clear.
> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel