[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver
> >>+static struct attribute *vtpm_attrs[] = { > >>+ &dev_attr_pubek.attr, > >>+ &dev_attr_pcrs.attr, > >>+ &dev_attr_enabled.attr, > >>+ &dev_attr_active.attr, > >>+ &dev_attr_owned.attr, > >>+ &dev_attr_temp_deactivated.attr, > >>+ &dev_attr_caps.attr, > >>+ &dev_attr_cancel.attr, > >>+ NULL, > >So are these going to show up in SysFS? If so, there should also be > >a corresponding file in Documentation/.../sysfs/something. > These are similar to the entries made by the other tpm drivers. I > don't see any documentation about those either. TPM maintainers, any > guidance there? Yep, those show up in sysfs. I'll put docs on my todo list. Kent > > > >>+#include "tpm.h" > >>+#include "tpm_vtpm.h" > >>+ > >>+#undef DEBUG > >>+ > >>+#define GRANT_INVALID_REF 0 > >Interesting. The 0 grant value is actually a valid one. I think you > >want (-1ULL). > Is it? > drivers/block/xen-blkfront.c and > drivers/net/xen-netfront.c > > do the exact same thing > >>+ > >>+ init_tpm_xenbus(); > >>+ return 0; > >>+} > >>+ > >>+ > >>+module_init(tpmif_init); > >no module_exit? > Will fix > > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |