Re: [Xen-devel] [PATCH, v3] fix build with XEN and EARLY_PRINTK_DBGP enabled but USB_SUPPORT disabled

[Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>]

On Fri, Nov 02, 2012 at 05:07:35PM +0000, Jan Beulich wrote:
> >>> On 02.11.12 at 18:01, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Fri, Nov 02, 2012 at 04:54:47PM +0000, Jan Beulich wrote:
> >> >>> On 02.11.12 at 17:23, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >> > On Fri, Nov 02, 2012 at 08:38:07AM +0000, Jan Beulich wrote:
> >> >> Since there's no possible caller of dbgp_external_startup() and
> >> > 
> >> > <snip>
> >> > 
> >> > Please just send the incremental patch, in a format that I can apply it
> >> > (hint, as an attachment like this I can't, as I would have to hand-edit
> >> > the attachment, and I might get it wrong...)
> >> 
> >> Here you go:
> >> 
> >> fix build of EHCI debug port code when USB_CHIPIDEA but !USB_EHCI_HCD
> >> 
> >> Relax condition of building the reset interface stubs in
> >> drivers/usb/early/ehci-dbgp.c from USB_EHCI_HCD to just USB, to also
> >> cover the chipidea driver re-using code from ehci-hcd.
> > 
> > Ok, I'm going to be a pain here, but this isn't in a form I can apply
> > it.  I would have to edit this by hand and then run it through git,
> > making it a pain to apply.  Please be nice to overworked maintainers and
> > make it easy to apply your patches, send them in a format that they
> > don't have to edit _anything_.
> > 
> > Third times a charm?
> 
> Assuming (since you didn't mention what's wrong) all this is about
> is the fact that the mail contains other text besides the patch, I'll
> resend the patch alone. If that's not your issue, you'll have to
> tell me what it is I did wrong.

Yes, that is incorrect, along with the Subject: line.

thanks,

greg k-h

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel