Re: [Xen-devel] [PATCH 02/02] Handles broken page occurred during migration

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

>> 
>> Given that logdirty is only enabled when we're doing some kind of
>> migration (Remus or otherwise), wouldn't it make sense to just
>> unconditionally call paging_mark_dirty(), rather than doing all this
>> stuff with vmce_monitor?  paging_mark_dirty() is already a no-op if
>> live-migration is not enabled; and if it is enabled, you probably
>> want whoever is using logdirty to go through and deal with the
>> broken page anyway.
> 
> That's just what I concerned -- can we guarantee paging log dirty
> mode only occur during live migration/remus? 
> say, under the case vram_tracking (hap_enable_vram_tracking) it also
> enable log dirty. 
> 
>> 
>> So it seems like you could just add paging_mark_dirty() to the
>> previous patch, and get rid of the rest of this patch entirely.
>> 
> 
> Currently I just find 2 cases which use log dirty mode: live
> migration/remus and vram tracking. So if we can make sure that log
> dirty would not used more in the future, it's fine to me to simplify
> my code by unconditionally call paging_mark_dirty at mce handler.   
> 
> What do you think?
> 
> Thanks,
> Jinsong

Anyway, I udpated first -- considering currently log dirty indeed only used by 
2 cases (migration and vram), I simplify the code and merge 2 patches into 1. 
Will send out via 'hg email'.

Thanks,
Jinsong
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel