diff -r e0b0a0132d1b -r 37d7243229b7 xen/arch/x86/cpu/mcheck/Makefile --- a/xen/arch/x86/cpu/mcheck/Makefile +++ b/xen/arch/x86/cpu/mcheck/Makefile @@ -8,7 +8,6 @@ obj-y += mctelem.o obj-y += mce.o obj-y += mce-apei.o obj-y += mce_intel.o -obj-y += mce_amd_quirks.o obj-y += non-fatal.o obj-y += util.o obj-y += vmce.o diff -r e0b0a0132d1b -r 37d7243229b7 xen/arch/x86/cpu/mcheck/mce_amd.c --- a/xen/arch/x86/cpu/mcheck/mce_amd.c +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c @@ -21,12 +21,24 @@ #include #include +#include #include "mce.h" #include "x86_mca.h" #include "mce_amd.h" #include "mcaction.h" +#include "mce_quirks.h" + +#define ANY -1 + +static const struct mce_quirkdata mce_amd_quirks[] = { + { 0xf /* cpu family */, ANY /* all models */, ANY /* all steppings */, + MCEQUIRK_K8_GART }, + { 0x10 /* cpu family */, ANY /* all models */, ANY /* all steppings */, + MCEQUIRK_F10_GART }, +}; + /* Error Code Types */ enum mc_ec_type { MC_EC_TLB_TYPE = 0x0010, @@ -99,6 +111,51 @@ mc_amd_addrcheck(uint64_t status, uint64 return 0; } +/* MC quirks */ +enum mcequirk_amd_flags +mcequirk_lookup_amd_quirkdata(struct cpuinfo_x86 *c) +{ + int i; + + BUG_ON(c->x86_vendor != X86_VENDOR_AMD); + + for (i = 0; i < ARRAY_SIZE(mce_amd_quirks); i++) { + if (c->x86 != mce_amd_quirks[i].cpu_family) + continue; + if ( (mce_amd_quirks[i].cpu_model != ANY) && + (mce_amd_quirks[i].cpu_model != c->x86_model) ) + continue; + if ( (mce_amd_quirks[i].cpu_stepping != ANY) && + (mce_amd_quirks[i].cpu_stepping != c->x86_mask) ) + continue; + return mce_amd_quirks[i].quirk; + } + return 0; +} + +int mcequirk_amd_apply(enum mcequirk_amd_flags flags) +{ + uint64_t val; + + switch (flags) { + case MCEQUIRK_K8_GART: + /* + * Enable error reporting for all errors except for GART + * TBL walk error reporting, which trips off incorrectly + * with AGP GART & 3ware & Cerberus. + */ + wrmsrl(MSR_IA32_MCx_CTL(4), ~(1ULL << 10)); + wrmsrl(MSR_IA32_MCx_STATUS(4), 0ULL); + break; + case MCEQUIRK_F10_GART: + if (rdmsr_safe(MSR_AMD64_MCx_MASK(4), val) == 0) + wrmsr_safe(MSR_AMD64_MCx_MASK(4), val | (1 << 10)); + break; + } + + return 0; +} + enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *ci) { diff -r e0b0a0132d1b -r 37d7243229b7 xen/arch/x86/cpu/mcheck/mce_amd_quirks.c --- a/xen/arch/x86/cpu/mcheck/mce_amd_quirks.c +++ /dev/null @@ -1,76 +0,0 @@ -/* - * MCA quirks for AMD CPUs - * Copyright (c) 2009 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - */ - -#include -#include - -#include "mce_quirks.h" - -#define ANY -1 - -static const struct mce_quirkdata mce_amd_quirks[] = { - { 0xf /* cpu family */, ANY /* all models */, ANY /* all steppings */, - MCEQUIRK_K8_GART }, - { 0x10 /* cpu family */, ANY /* all models */, ANY /* all steppings */, - MCEQUIRK_F10_GART }, -}; - -enum mcequirk_amd_flags -mcequirk_lookup_amd_quirkdata(struct cpuinfo_x86 *c) -{ - int i; - - BUG_ON(c->x86_vendor != X86_VENDOR_AMD); - - for (i = 0; i < ARRAY_SIZE(mce_amd_quirks); i++) { - if (c->x86 != mce_amd_quirks[i].cpu_family) - continue; - if ( (mce_amd_quirks[i].cpu_model != ANY) && - (mce_amd_quirks[i].cpu_model != c->x86_model) ) - continue; - if ( (mce_amd_quirks[i].cpu_stepping != ANY) && - (mce_amd_quirks[i].cpu_stepping != c->x86_mask) ) - continue; - return mce_amd_quirks[i].quirk; - } - return 0; -} - -int mcequirk_amd_apply(enum mcequirk_amd_flags flags) -{ - u64 val; - - switch (flags) { - case MCEQUIRK_K8_GART: - /* - * Enable error reporting for all errors except for GART - * TBL walk error reporting, which trips off incorrectly - * with AGP GART & 3ware & Cerberus. - */ - wrmsrl(MSR_IA32_MCx_CTL(4), ~(1ULL << 10)); - wrmsrl(MSR_IA32_MCx_STATUS(4), 0ULL); - break; - case MCEQUIRK_F10_GART: - if (rdmsr_safe(MSR_AMD64_MCx_MASK(4), val) == 0) - wrmsr_safe(MSR_AMD64_MCx_MASK(4), val | (1 << 10)); - break; - } - - return 0; -}