Re: [Xen-devel] [PATCH 1/2, v2] x86: use MOV instead of PUSH/POP when saving/restoring register state

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.10.12 at 16:19, Mats Petersson <mats.petersson@xxxxxxxxxx> wrote:
> On 30/10/12 14:27, Jan Beulich wrote:
>> --- a/xen/include/asm-x86/x86_64/asm_defns.h
>> +++ b/xen/include/asm-x86/x86_64/asm_defns.h
>> @@ -5,11 +5,11 @@
>>   
>>   #ifdef CONFIG_FRAME_POINTER
>>   /* Indicate special exception stack frame by inverting the frame pointer. 
> */
>> -#define SETUP_EXCEPTION_FRAME_POINTER           \
>> -        movq  %rsp,%rbp;                        \
>> +#define SETUP_EXCEPTION_FRAME_POINTER(offs)     \
>> +        leaq  offs(%rsp),%rbp;                  \
>>           notq  %rbp
>>   #else
>> -#define SETUP_EXCEPTION_FRAME_POINTER
>> +#define SETUP_EXCEPTION_FRAME_POINTER(off)
> Is it too pedantic to say that "off" here should be "offs"?
> Just for consistency...

It doesn't really matter, but I adjusted this in the copy that
may eventually get committed - for consistency, as you say.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel